fix/improved user info retention on signup/login forms

app.js

@@ -59,18 +59,16 @@ app.get('/signup', (req, res) => {
 
     const ignore = ["User not found", "Incorrect password"];
     if (ignore.includes(error)) error = "";
-    res.render('signup', { errMessage: error });
-    return res.status(status.Ok);
-});
     
-app.get('/signup/:name/:email', (req, res) => {
+    if (req.query.name && req.query.email) {
-    const ignore = ["User not found", "Incorrect password"];
-    if (ignore.includes(req.session.errMessage)) req.session.errMessage = "";
         res.render('signup', { 
-        errMessage: req.session.errMessage,
+            errMessage: error,
-        name: req.params.name,
+            name: req.query.name,
-        email: req.params.email
+            email: req.query.email
         });    
+    } else {
+        res.render('signup', { errMessage: error });
+    }
     return res.status(status.Ok);
 });
 
@@ -79,7 +77,15 @@ app.get('/login', (req, res) => {
         res.redirect("/home");
         return res.status(status.Ok);
     }
+
+    if (req.query.email) {
+        res.render('login', { 
+            errMessage: req.session.errMessage,
+            email: req.query.email
+        });
+    } else {
         res.render('login', { errMessage: req.session.errMessage });
+    }
     return res.status(status.Ok);
 });
 

src/auth/authentication.js

@@ -43,13 +43,13 @@ module.exports = (users) => {
             if (!user) {
                 req.session.errMessage = "User not found";
                 res.status(status.NotFound);
-                return res.redirect("/login");
+                return res.redirect(`/login/?email=${req.body.email}`);
             }
 
             if (!bcrypt.compareSync(req.body.password, user.password)) {
                 req.session.errMessage = "Incorrect password";
                 res.status(status.Unauthorized);
-                return res.redirect("/login");
+                return res.redirect(`/login/?email=${req.body.email}`);
             }
 
             req.session.authenticated = true;
@@ -96,7 +96,7 @@ module.exports = (users) => {
         if (req.body.password != req.body.repassword) {
             req.session.errMessage = "Passwords must match";
             res.status(status.BadRequest);
-            return res.redirect(`/signup/${req.body.name}/${req.body.email}`);
+            return res.redirect(`/signup/?name=${req.body.name}&email=${req.body.email}`);
         }
 
         let strength = passwordStrength(req.body.password);
@@ -104,7 +104,7 @@ module.exports = (users) => {
         if (strength.id < 2) {
             req.session.errMessage = `Password ${strength.value}`;
             res.status(status.BadRequest);
-            return res.redirect(`/signup/${req.body.name}/${req.body.email}`);
+            return res.redirect(`/signup/?name=${req.body.name}&email=${req.body.email}`);
         }
 
         let hashedPassword = await bcrypt.hashSync(req.body.password, salt);

src/views/login.ejs

@@ -11,7 +11,7 @@
                     <label for="email" class="block text-base mb-2 text-slate-600">Email</label>
                     <input type="text" id="email" name="email"
                         class="border border-slate-300 focus:border-indigo-500 w-full rounded-md text-base px-3 py-2 focus:outline-none focus:ring-1 focus:ring-indigo-500 transition-colors duration-200"
-                        placeholder="Enter Email" />
+                        placeholder="Enter Email" value="<%= typeof email != 'undefined' ? email : '' %>"/>
                 </div>
                 <div class="mt-4">
                     <label for="password" class="block text-base mb-2 text-slate-600">Password</label>