update/create middleware

app.js

@@ -1,34 +1,36 @@
+const status = require("./src/util/statuses");
+const MongoStore = require("connect-mongo");
+const session = require("express-session");
 const express = require('express');
 const path = require('path');
-const session = require("express-session");
-const MongoStore = require("connect-mongo");
 require('dotenv').config();
 
 const app = express();
 const port = process.env.PORT || 3000;
 
+const mongoURI = process.env.mongoURI || "mongodb://localhost:27017/";
+const database = process.env.database || "knoldus"; // Database name
+const secret   = process.env.secret   || "123-secret-xyz";
+
+/*** Sessions ***/
+app.use(session({
+    secret: secret,
+    store: MongoStore.create({ mongoUrl: `${mongoURI}${database}`, crypto: { secret: secret } }),
+    resave: true,
+    saveUninitialized: false,
+    cookie: { maxAge: 60000 },
+}));
+
 app.set('view engine', 'ejs');
 app.set('views',path.join(__dirname, 'src/views'));
 app.use(express.urlencoded({ extended: true }));
 app.use("/static", express.static("./src/public"));
 
-/*** Sessions ***/
-app.use(session({
-    secret: config.express_secret,
-    store: MongoStore.create({ mongoUrl: `${mongoURI}/${config.mongo_database}`, crypto: { secret: config.mongo_secret } }),
-    resave: true,
-    saveUninitialized: false,
-    cookie: { maxAge: 60000 },
-}));
-
 /*** Database ***/
 const { connectMongo, getCollection } = require("./src/database/connection");
 
 let users;
 async function initDatabase() {
-    const mongoURI = process.env.mongoURI || "mongodb://localhost:27017/";
-    const database = process.env.database || "knoldus"; // Database name
-    
     const db = await connectMongo(mongoURI, database);
     
     // For any collection, init here
@@ -36,7 +38,14 @@ async function initDatabase() {
 }
 
 initDatabase().then(() => {
-    require("./src/auth/authentication")(app, users);
+    // Import authentication handler
+    app.use(require("./src/auth/authentication")(users));
+
+    // Import middleware
+    const middleware = require("./src/auth/middleware")(users);
+
+    // Apply middleware to protected user routes
+    app.use(require("./src/router/user")(middleware));
 });
 
 /*** ROUTINGS ***/
@@ -44,65 +53,36 @@ initDatabase().then(() => {
 app.get('/', (req, res) => {
     if (!req.session.errMessage) req.session.errMessage = "";
     res.render('index');
-    return res.status(200);
+    return res.status(status.Ok);
 });
 
 app.get('/landing', (req, res) => {
     res.render('landing');
-    return res.status(200);
+    return res.status(status.Ok);
 });
 
 app.get('/signup', (req, res) => {
     res.render('signup', { errMessage: req.session.errMessage });
-    return res.status(200);
+    return res.status(status.Ok);
 });
 
 app.get('/login', (req, res) => {
     if (req.session.authenticated) {
-        
+        res.redirect("/home");
+        return res.status(status.Ok);        
     }
     res.render('login', { errMessage: req.session.errMessage });
-    return res.status(200);
-});
-
-app.get('/home', (req, res) => {
-    res.render('home');
-    return res.status(200);
-});
-
-app.get('/assets', (req, res) => {
-    res.render('assets');
-    return res.status(200);
-});
-
-app.get('/plans', (req, res) => {
-    res.render('plans');
-    return res.status(200);
-});
-
-app.get('/more', (req, res) => {
-    res.render('more');
-    return res.status(200);
-});
-
-app.get('/profile', (req, res) => {
-    res.render('profiles');
-    return res.status(200);
-});
-
-app.get('/settings', (req, res) => {
-    res.render('settings');
-    return res.status(200);
+    return res.status(status.Ok);
 });
 
 app.get('/aboutUs', (req, res) => {
     res.render('aboutUs');
-    return res.status(200);
+    return res.status(status.Ok);
 });
 
 app.get('/*splat', (req, res) => {
     res.send('404 Not Found');
-    return res.status(404);
+    return res.status(status.NotFound);
 });
 
 app.listen(port, () => {

src/auth/authentication.js

@@ -1,9 +1,12 @@
-const joi = require("joi");
+const status = require("../util/statuses");
 const bcrypt = require('bcrypt');
+const joi = require("joi");
 const salt = 12;
 
-module.exports = (app, users) => {
-    app.post("/login", async (req, res) => {
+module.exports = (users) => {
+    const router = require("express").Router();
+    
+    router.post("/login", async (req, res) => {
         const credentialSchema = joi.object({
             email: joi.string().email().required(),
             password: joi.string().max(20).required(),
@@ -13,32 +16,33 @@ module.exports = (app, users) => {
 
         if (valid.err) {
             req.session.errMessage = "Invalid input";
-            res.status(400);
+            res.status(status.BadRequest);
             return res.redirect("/login");
         }
 
         users.findOne({ "email": req.body.email }).then((user) => {
             if (!user) {
                 req.session.errMessage = "User not found";
-                res.status(404);
-                return res.redirect("/login");                
+                res.status(status.NotFound);
+                return res.redirect("/login");
             }
 
             if (!bcrypt.compare(req.body.password, user.password)) {
                 req.session.errMessage = "Incorrect password";
-                res.status(401);
+                res.status(status.Unauthorized);
                 return res.redirect("/login");
             }
 
-            // ignorin sessions for now just have basic login for demo
-            // TODO: actually add sessions
+            req.session.authenticated = true;
+            req.session.email = req.body.email;
 
             req.session.errMessage = "";
             res.redirect("/home");
+            return res.status(status.Ok);
         });
     });
 
-    app.post("/signup", async (req, res) => {
+    router.post("/signup", async (req, res) => {
         const userSchema = joi.object({
             email: joi.string().email().required(),
             // name: joi.string().alphanum().max(20).required(),
@@ -50,13 +54,13 @@ module.exports = (app, users) => {
 
         if (valid.err) {
             req.session.errMessage = "Invalid input",
-            res.status(400);
+            res.status(status.BadRequest);
             return res.redirect("/signup");
         }
 
         if (req.body.password != req.body.repassword) {
             req.session.errMessage = "Passwords must match";
-            res.status(400);
+            res.status(status.BadRequest);
             return res.redirect("/signup");
         }
 
@@ -68,15 +72,25 @@ module.exports = (app, users) => {
             password: hashedPassword,
         }).then((results, err) => {
             if (err) {
-                res.status(500);
+                res.status(status.InternalServerError);
                 console.error(err);
                 return res.send("Internal server error");
             }
 
-            // TODO: Add session handling here and auto redirect to home and be authenticated
-            req.session.errMessage = "Please login to view that resource";
-            res.status(200);
-            return res.redirect("/login");
+            req.session.authenticated = true;
+            req.session.email = req.body.email;
+
+            req.session.errMessage = "";
+            res.status(status.Ok);
+            return res.redirect("/home");
         });
     });
+
+    router.get("/logout", (req, res) => {
+        req.session.destroy();
+        // res.status(status.Unauthorized);
+        return res.redirect('/login');
+    });
+
+    return router;
 }

src/auth/middleware.js

@@ -0,0 +1,22 @@
+const status = require("../util/statuses");
+
+module.exports = (users) => {
+    return async (req, res, next) => {
+        if (!req.session.authenticated || !req.session.email) {
+            req.session.errMessage = "Please login to view that resource";
+            res.redirect("/login");
+            return res.status(status.Unauthorized);
+        }
+    
+        let user = await users.findOne({ "email": req.session.email }).then((user) => user);
+    
+        if (!user) {
+            req.session.errMessage = "User not found";
+            res.redirect("/login");
+            return res.status(status.Unauthorized);
+        }
+    
+        req.user = user;
+        next();
+    }
+};

src/router/user.js

@@ -0,0 +1,35 @@
+module.exports = (middleware) => {
+    const router = require("express").Router();
+
+    router.get('/home', middleware, async (req, res) => {
+        res.render('home', { user: req.user });
+        return res.status(status.Ok);
+    });
+
+    router.get('/assets', middleware, (req, res) => {
+        res.render('assets', { user: req.user });
+        return res.status(status.Ok);
+    });
+
+    router.get('/plans', middleware, (req, res) => {
+        res.render('plans', { user: req.user });
+        return res.status(status.Ok);
+    });
+
+    router.get('/more', middleware, (req, res) => {
+        res.render('more', { user: req.user });
+        return res.status(status.Ok);
+    });
+
+    router.get('/profile', middleware, (req, res) => {
+        res.render('profiles', { user: req.user });
+        return res.status(status.Ok);
+    });
+
+    router.get('/settings', middleware, (req, res) => {
+        res.render('settings', { user: req.user });
+        return res.status(status.Ok);
+    });
+
+    return router;
+};

src/util/statuses.js

@@ -0,0 +1,7 @@
+module.exports = {
+    Ok:                  200,
+    BadRequest:          400,
+    Unauthorized:        401,
+    NotFound:            404,
+    InternalServerError: 500,
+};