From 60d029433d786e2ed1eb45bfe6f8de1c9076c117 Mon Sep 17 00:00:00 2001
From: Braeden57 <sowinskibraeden@gmail.com>
Date: Sun, 4 Apr 2021 21:57:34 -0700
Subject: [PATCH] No-Quest-ID-catch

---
 views/quests.ejs | 37 +++++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 16 deletions(-)

diff --git a/views/quests.ejs b/views/quests.ejs
index 6b6ddcb..a6a1f37 100644
--- a/views/quests.ejs
+++ b/views/quests.ejs
@@ -15,22 +15,27 @@
   // Catch url Parameter
   window.onload = function () {
     const queryString = window.location.search;
-    const urlParams = new URLSearchParams(queryString);
-    const id = urlParams.get('id');
-    <% if(quests.length == 0) { %>
-      document.getElementById('div-container').innerHTML = "<h2>Uh oh, theres no quests :(</h2>";
-    <% } else if(quests.length > 0) { %>
-      <% quests.forEach(function (quest) { %>
-        if('<%= quest._id %>' == id) {
-          document.getElementById('div-container').innerHTML += '<div id="quest">';
-          document.getElementById('quest').innerHTML += '<h1 class="title"><%= quest.title %></h1>';
-          document.getElementById('quest').innerHTML += '<h2 class="title">Campaign: <%= quest.campaign %></h2>'
-          document.getElementById('quest').innerHTML += '<p class="info">XP: <%= quest.xp %></p>';
-          document.getElementById('quest').innerHTML += '<p class="info">Expires: <%= quest.expiry %></p>';
-          document.getElementById('quest').innerHTML += `<h3 class="info">Instructions: <%= quest.instruction %></h3>`;
-        }
-      <% }) %>
-    <% } %>
+    if (queryString != null) {
+      const urlParams = new URLSearchParams(queryString);
+      const id = urlParams.get('id');
+      document.getElementById('div-container').innerHTML = "<h2>Uh oh, there was an issue getting the quest id! :(</h2>";
+      <% if(quests.length == 0) { %>
+        document.getElementById('div-container').innerHTML = "<h2>Uh oh, theres no quests :(</h2>";
+        <% } else if(quests.length > 0) { %>
+          <% quests.forEach(function (quest) { %>
+            if('<%= quest._id %>' == id) {
+              document.getElementById('div-container').innerHTML += '<div id="quest">';
+                document.getElementById('quest').innerHTML += '<h1 class="title"><%= quest.title %></h1>';
+                document.getElementById('quest').innerHTML += '<h2 class="title">Campaign: <%= quest.campaign %></h2>'
+                document.getElementById('quest').innerHTML += '<p class="info">XP: <%= quest.xp %></p>';
+                document.getElementById('quest').innerHTML += '<p class="info">Expires: <%= quest.expiry %></p>';
+                document.getElementById('quest').innerHTML += `<h3 class="info">Instructions: <%= quest.instruction %></h3>`;
+              }
+              <% }) %>
+              <% } %>
+    } else {
+      document.getElementById('div-container').innerHTML = "<h2>Uh oh, there was an issue getting the quest id :(</h2>";
+    }
   }
 </script>