update/limit-leaderboard-for-greater-limit

commands/bank.js

@@ -143,7 +143,7 @@ module.exports = {
         // prevent sending transfering money to self
         const targetUserID = args[0].options[0].value.replace('<@!', '').replace('>', '');
 
-        if  (targetUserID == interaction.member.user.id) return interaction.send({ embeds: [new EmbedBuilder().setDescription('**Invalid** You may not transfer money to yourself').setColor(client.config.Colors.Yellow)], flags: (1 << 6) })
+        if (targetUserID == interaction.member.user.id) return interaction.send({ embeds: [new EmbedBuilder().setDescription('**Invalid** You may not transfer money to yourself').setColor(client.config.Colors.Yellow)], flags: (1 << 6) })
 
         if (banking.guilds[GuildDB.serverID].balance.toFixed(2) - args[0].options[1].value < 0) {
           let embed = new EmbedBuilder()

commands/leaderboard.js

@@ -90,6 +90,8 @@ module.exports = {
 
       let des = ``;
       for (let i = 0; i < limit; i++) {
+        if (leaderboard.length < limit && i == leaderboard.length) break;
+        
         let stats = category == 'kills' ? `${leaderboard[i].kills} Kill${(leaderboard[i].kills>1||leaderboard[i].kills==0)?'s':''}` :
                     category == 'killstreak' ? `${leaderboard[i].killStreak} Player Killstreak` :
                     category == 'best_killstreak' ? `${leaderboard[i].bestKillStreak} Player Killstreak` :

commands/money.js

@@ -91,8 +91,8 @@ module.exports = {
 
         // Register bank for user  
         let newBank = new User();
-        await newBank.createUser(targetUserID, GuildDB.serverID, GuildDB.startingBalance);
+        newBank.createUser(targetUserID, GuildDB.serverID, GuildDB.startingBalance);
-        await newBank.save().catch(err => {
+        newBank.save().catch(err => {
           if (err) return client.sendInternalError(interaction, err);
         });
         

package.json

@@ -1,6 +1,6 @@
 {
   "name": "dayz-armbands",
-  "version": "8.3.5",
+  "version": "8.3.6",
   "description": "A General Purpose Discord Bot for DayZ Servers.",
   "main": "index.js",
   "nodemonConfig": {