fix/infinite-money-transfer-to-self

commands/bank.js

@@ -139,7 +139,12 @@ module.exports = {
 
       } else if (args[0].name == 'transfer') {
         // send money from bank
-          
+
+        // prevent sending transfering money to self
+        const targetUserID = args[0].options[0].value.replace('<@!', '').replace('>', '');
+
+        if  (targetUserID == interaction.member.user.id) return interaction.send({ embeds: [new EmbedBuilder().setDescription('**Invalid** You may not transfer money to yourself').setColor(client.config.Colors.Yellow)], flags: (1 << 6) })
+
         if (banking.guilds[GuildDB.serverID].balance.toFixed(2) - args[0].options[1].value < 0) {
           let embed = new EmbedBuilder()
             .setTitle('**Bank Notice:** NSF. Non sufficient funds')
@@ -154,7 +159,6 @@ module.exports = {
           if (err) return client.sendInternalError(interaction, err);
         });
 
-        const targetUserID = args[0].options[0].value.replace('<@!', '').replace('>', '');
         let targetUserBanking = await client.dbo.collection("users").findOne({"user.userID": targetUserID}).then(banking => banking);
 
         if (!targetUserBanking) {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "dayz-armbands",
-  "version": "8.3.4",
+  "version": "8.3.5",
   "description": "A General Purpose Discord Bot for DayZ Servers.",
   "main": "index.js",
   "nodemonConfig": {