From e8d086de1d01e2fcfbca9f4e59fe90fbf733db03 Mon Sep 17 00:00:00 2001 From: Braeden Sowinski Date: Thu, 9 Nov 2023 09:50:41 -0800 Subject: [PATCH] fix/updating lowestCombatRating --- commands/player-stats.js | 6 ++++-- package.json | 2 +- util/KillfeedHandler.js | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/commands/player-stats.js b/commands/player-stats.js index cc0525a..040f479 100644 --- a/commands/player-stats.js +++ b/commands/player-stats.js @@ -231,8 +231,10 @@ module.exports = { let data = query.combatRatingHistory; - if (!client.exists(query.highestCombatRating)) query.highestCombatRating = Math.max(...query.combatRatingHistory); - if (!client.exists(query.lowestCombatRating)) query.lowestCombatRating = Math.min(...query.combatRatingHistory); + let dataMax = Math.max(...query.combatRatingHistory); + let dataMin = Math.min(...query.combatRatingHistory); + if (!client.exists(query.highestCombatRating) || query.highestCombatRating < dataMax) query.highestCombatRating = dataMax; + if (!client.exists(query.lowestCombatRating) || query.lowestCombatRating > dataMin) query.lowestCombatRating = dataMin; statsEmbed.addFields( { name: 'Combat Rating', value: `${query.combatRating}`, inline: true }, diff --git a/package.json b/package.json index b6f87aa..1efde44 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "dayzr-bot", - "version": "12.3.12", + "version": "12.3.13", "description": "A General Purpose Discord Bot for DayZ Nitrado Servers.", "main": "index.js", "nodemonConfig": { diff --git a/util/KillfeedHandler.js b/util/KillfeedHandler.js index 5632875..59fd4f8 100644 --- a/util/KillfeedHandler.js +++ b/util/KillfeedHandler.js @@ -194,7 +194,7 @@ module.exports = { killerStat.combatRating = calculateNewCombatRating(killerStat.combatRating, victimStat.combatRating, client.exists(info.bodyPart) && info.bodyPart.includes('Head') ? 1.25 : 1); victimStat.combatRating = calculateNewCombatRating(victimStat.combatRating, killerStat.combatRating, 0); if (killerStat.combatRating > killerStat.highestCombatRating) killerStat.highestCombatRating = killerStat.combatRating; - if (victimStat.combatRating < victimStat.lowestCombatRating) killerStat.lowestCombatRating = victimStat.combatRating; + if (victimStat.combatRating < victimStat.lowestCombatRating) victimStat.lowestCombatRating = victimStat.combatRating; if (killerStat.combatRatingHistory.length >= 12) killerStat.combatRatingHistory = killerStat.combatRatingHistory.slice(1); // Remove first element (limits history to length 12) if (victimStat.combatRatingHistory.length >= 12) victimStat.combatRatingHistory = victimStat.combatRatingHistory.slice(1); // Remove first element (limits history to length 12) killerStat.combatRatingHistory.push(killerStat.combatRating);