From b396cd742b25ef40946746d349a19c16b16cc05f Mon Sep 17 00:00:00 2001 From: SowinskiBraeden Date: Mon, 22 Jan 2024 20:57:30 -0800 Subject: [PATCH] fix deleted role detection --- structures/LinesPoliceCadBot.js | 9 ++++----- util/Logger.js | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/structures/LinesPoliceCadBot.js b/structures/LinesPoliceCadBot.js index 0ab6ced..6f43ea0 100644 --- a/structures/LinesPoliceCadBot.js +++ b/structures/LinesPoliceCadBot.js @@ -271,10 +271,11 @@ class LinesPoliceCadBot extends Client { if (!customRoleStatus) return false; // There is no role limits // Clear any deleted roles - const guild = await this.guilds.cache.get(serverID); let filteredRoles = []; let update = false; - for (let i = 0; i < guild.server.allowedRoles.length; i++) { + let guildDB = this.dbo.collection.findOne({ 'server.serverID': serverID }).then(guildDB => guildDB) + for (let i = 0; i < guildDB.server.allowedRoles.length; i++) { + const guild = await this.guilds.cache.get(serverID); const role = guild.roles.cache.find(role => role.id == guild.server.allowedRoles[i]) if (role) filteredRoles.push(role); if (!role) update = true; @@ -292,9 +293,7 @@ class LinesPoliceCadBot extends Client { } let hasRole = await this.checkRoleStatus(rolesCache, serverID, isList); - if (!hasRole) return false; // User does not have role - - return true; // User has role + return hasRole; } log(Text) { this.logger.log(Text); } diff --git a/util/Logger.js b/util/Logger.js index 84965d0..ef7ffc3 100644 --- a/util/Logger.js +++ b/util/Logger.js @@ -31,7 +31,7 @@ class Logger { message: `${d.getHours()}:${ d.getMInutes - } - ${d.getData()}:${d.getMonth()}:${d.getFullYear()} | Error: ` + Text, + } - ${d.getDate()}:${d.getMonth()}:${d.getFullYear()} | Error: ` + Text, }); console.log( colors.green(